Skip to content

Register nested attributes#17

Merged
sondrelg merged 1 commit intomasterfrom
nested-attributes
Apr 1, 2021
Merged

Register nested attributes#17
sondrelg merged 1 commit intomasterfrom
nested-attributes

Conversation

@sondrelg
Copy link
Copy Markdown
Member

@sondrelg sondrelg commented Mar 31, 2021

Code like this

import proj.app.enums

class Migration:
    enum=proj.app.enums.EnumClass

which is just a simplified example of a Django migration file, was flagging false positives.

The problem is that the current code does not register that proj.app.enums.EnumClass is related to the proj.app.enums import in any way.

I'm not super excited about this way of solving the problem, but this fixes the test example without breaking the existing test suite. Any feedback here, on how it might be cleaned up is much appreciated @JonasKs

@sondrelg sondrelg requested a review from JonasKs March 31, 2021 23:02
@sondrelg sondrelg self-assigned this Mar 31, 2021
@sondrelg sondrelg merged commit 8082372 into master Apr 1, 2021
@sondrelg sondrelg deleted the nested-attributes branch April 1, 2021 08:19
sondrelg added a commit that referenced this pull request Oct 16, 2022
This is causing problems for plugins running after this one.

I can't remember why these lines were added, and removing them doesn't break any tests. I think they were left in by mistake in #17.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant