Conversation
sondrelg
added a commit
that referenced
this pull request
Oct 16, 2022
This is causing problems for plugins running after this one. I can't remember why these lines were added, and removing them doesn't break any tests. I think they were left in by mistake in #17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code like this
which is just a simplified example of a Django migration file, was flagging false positives.
The problem is that the current code does not register that
proj.app.enums.EnumClassis related to theproj.app.enumsimport in any way.I'm not super excited about this way of solving the problem, but this fixes the test example without breaking the existing test suite. Any feedback here, on how it might be cleaned up is much appreciated @JonasKs