New MCMC example, Matrix unit tests & bug fixes#83
Merged
willp240 merged 5 commits intosnoplus:masterfrom Apr 29, 2026
Merged
Conversation
willp240
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a few things at once:
examples/MCMC.cpp, which goes through the process of setting up and running a Metropolis MCMC chain under realistic conditions. This is intended both as an example piece of code for new users, and as a piece of code that can be used to test the performance of future changes to OXO.SparseMatrixandDenseMatrixclasses, as none currently exist. These ensure that with any future changes to these classes, e.g. if we change how we handle matrices underneath, we can easily test that theSparseMatrixandDenseMatrixinterfaces have remained unchanged.fNColsandfNRowsmember variables were not updated in the output during multiplicationoperator*()method for theDenseMatrixclass, one of the input matrices would be modified to the product matrix!