Skip to content

Revert code to test openrewrite classloading fix#100

Merged
cmoulliard merged 6 commits intomainfrom
revert-code-to-test-openrewrite-classloading-fix
Mar 11, 2026
Merged

Revert code to test openrewrite classloading fix#100
cmoulliard merged 6 commits intomainfrom
revert-code-to-test-openrewrite-classloading-fix

Conversation

@cmoulliard
Copy link
Member

@cmoulliard cmoulliard commented Mar 10, 2026

  • Remove the annotation @QuarkusTest to the test RecipesJarTSVFileTest class to avoid to pollute the classpath and to get such annoying error: class org.openrewrite.maven.table.ExplainDependenciesInUse cannot be cast to class org.openrewrite.maven.table.DependenciesInUse
  • Reverting the code to avoid to use Reflection and directly RewriteService.
  • !! we use openrewrite 8.76.0-SNAPSHOT as the fix of TypeTable to load the TSV classpath.gz file has not been yet released.

…vice. Use 8.26.0-SNAPSHOT as the fix of TypeTable to load the TSV classpath.gz file is not yet released.

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
…and to get such annoying error: class org.openrewrite.maven.table.ExplainDependenciesInUse cannot be cast to class org.openrewrite.maven.table.DependenciesInUse

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
…eName but also the Row type to avoid a classcast exception

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
@cmoulliard cmoulliard marked this pull request as ready for review March 11, 2026 08:39
@cmoulliard cmoulliard requested a review from aureamunoz March 11, 2026 08:39
…endency

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
…issue with TypeTable

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
…chResults on Datatable

Signed-off-by: Charles Moulliard <cmoulliard@ibm.com>
Copy link
Contributor

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good if commits are squashed ;-)

@cmoulliard cmoulliard merged commit ac87b5c into main Mar 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants