[Makefile] new optional helper to remove unused imports#148
Merged
sfc-gh-sbekman merged 3 commits intomainfrom Apr 14, 2025
Merged
[Makefile] new optional helper to remove unused imports#148sfc-gh-sbekman merged 3 commits intomainfrom
sfc-gh-sbekman merged 3 commits intomainfrom
Conversation
Signed-off-by: Stas Bekman <stas.bekman@snowflake.com>
sfc-gh-sbekman
requested review from
sfc-gh-caxu,
sfc-gh-jrasley,
sfc-gh-mwyatt,
sfc-gh-srajbhandari and
sfc-gh-zhyao
as code owners
sfc-gh-mwyatt
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is superuseful when mixing or splicing many py files together to quickly remove unused imports.
but it could have bad side-effects, so making it into an optional target to be used only when it's really saving time.
cc: @sfc-gh-mwyatt