Skip to content

liger-kernel: cleanly report when a model isn't supported#269

Merged
sfc-gh-sbekman merged 3 commits intomainfrom
stas/liger-arch-not-found
Sep 10, 2025
Merged

liger-kernel: cleanly report when a model isn't supported#269
sfc-gh-sbekman merged 3 commits intomainfrom
stas/liger-arch-not-found

Conversation

@sfc-gh-sbekman
Copy link
Copy Markdown
Collaborator

@sfc-gh-sbekman sfc-gh-sbekman commented Aug 22, 2025 •
edited
Loading

with this PR when liger-kernel doesn't support a model arch, it'll throw a user-friendly exception, like:

[rank6]: ValueError: It appears that liger-kernel==0.6.2 doesn't support the architecture of 
ibm-granite/granite-3.0-3b-a800m-instruct, perhaps try the latest liger-kernel version. 
It can't find 'granitemoe'.

@sfc-gh-sbekman
liger-kernel: cleanly report when a model isn't supported
a7a8a17 
Signed-off-by: Stas Bekman <stas.bekman@snowflake.com>
@sfc-gh-sbekman sfc-gh-sbekman requested review from sfc-gh-mwyatt and removed request for sfc-gh-jrasley August 22, 2025 18:10
@sfc-gh-sbekman sfc-gh-sbekman enabled auto-merge (squash) August 22, 2025 18:11
@sfc-gh-sbekman
Copy link
Copy Markdown
Collaborator Author

sfc-gh-sbekman commented Aug 29, 2025

@sfc-gh-mwyatt ? let's merge this one? should take a sec to review

@sfc-gh-sbekman sfc-gh-sbekman merged commit c2ca21e into main Sep 10, 2025
4 checks passed
@sfc-gh-sbekman sfc-gh-sbekman deleted the stas/liger-arch-not-found branch September 10, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mwyatt sfc-gh-mwyatt sfc-gh-mwyatt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfc-gh-sbekman @sfc-gh-mwyatt