tiled mlp: auto-monkeypatch#290
Merged
sfc-gh-sbekman merged 4 commits intomainfrom Oct 9, 2025
Merged
Conversation
Signed-off-by: Stas Bekman <stas.bekman@snowflake.com>
Signed-off-by: Stas Bekman <stas.bekman@snowflake.com>
sfc-gh-sbekman
requested review from
sfc-gh-truwase
and removed request for
sfc-gh-jrasley
Collaborator
Author
|
@sfc-gh-truwase, this is now ready to be merged if you could review please. Thank you. |
sfc-gh-truwase
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For TiledMLP
https://github.com/axolotl-ai-cloud/axolotl/blob/ce74c20109d60df4cb023254f3a58b80b6a4cfc8/src/axolotl/monkeypatch/tiled_mlp/patch.py#L22-L27
x.shapeis not[bs, seqlen, hidden]but[seqlen, hidden]This also requires deepspeedai/DeepSpeed#7622 which has been merged and ds=0.18.0 has been released.