Jw/snow 2131951 less freqent update messages

[sfc-gh-jwilkowski]

Pre-review checklist

• I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
• I've added or updated automated unit tests to verify correctness of my new code.
• I've added or updated integration tests to verify correctness of my new code.
• I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
• I've confirmed that my changes are working by executing CLI's commands manually on Windows.
• I've confirmed that my changes are up-to-date with the target branch.
• I've described my changes in the release notes.
• I've described my changes in the section below.

Changes description

https://snowflakecomputing.atlassian.net/browse/SNOW-2131951

[sfc-gh-pczajka]

I'd separate this logic from _VersionCache - I imagine this class as a layer for reading/writing the cache file

[sfc-gh-jwilkowski]

What would you suggest instead? I agree that the original intent of _VersionCache was probably to not hit pypi too often, but our requirements have changed. If we were very strict, the info when upgrade message was last displayed could go to another file, but that seems to be adding more complexity if you ask me. After all _last_time_shown is also related to the functionality of displaying version upgrade message, so I'd rather have that in a single file instead of worrying about management of another file.

[sfc-gh-pczajka]

How about returning last_time_shown: Optional[int] and doing a comparison with a constant in get_new_version_msg?

[sfc-gh-jwilkowski]

ok, that sounds like a good idea 👌