Skip to content

NO-SNOW: Disable Stored Proc telemetry by default #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sfc-gh-aalam merged 2 commits into from
Sep 8, 2025
Merged

NO-SNOW: Disable Stored Proc telemetry by default #3701

sfc-gh-aalam merged 2 commits into from
Sep 8, 2025

Conversation

@sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Aug 25, 2025 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Sep 5, 2025
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review September 5, 2025 22:44
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners September 5, 2025 22:44
sfc-gh-jrose
sfc-gh-jrose approved these changes Sep 5, 2025
View reviewed changes
src/snowflake/snowpark/_internal/telemetry.py Outdated
# except ImportError:
# internal_metrics_available = False

# TODO: Enable this once we have re-factored the telemetry to use otel metrics
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a ticket number?

Copy link
Contributor Author

@sfc-gh-aalam sfc-gh-aalam Sep 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://snowflakecomputing.atlassian.net/browse/SNOW-2321754

@sfc-gh-aalam sfc-gh-aalam merged commit 54cad0e into main Sep 8, 2025
28 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-NO-SNOW-disable-sproc-telemetry branch September 8, 2025 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-mayliu sfc-gh-mayliu Awaiting requested review from sfc-gh-mayliu sfc-gh-mayliu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

No one assigned

Labels

NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-aalam @sfc-gh-jdu @sfc-gh-jrose