Skip to content

Conversation

@sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Oct 21, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes a regression introduced in #3812, **kwargs will lead to multiple values for argument TypeError as users may mis-use the public facing api

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review October 21, 2025 16:31
@sfc-gh-aling sfc-gh-aling requested review from a team as code owners October 21, 2025 16:31
@sfc-gh-aling sfc-gh-aling changed the title SNOW-2436917: fix regression main branch SNOW-2436917: fix udxf/sproc registeration regression main branch Oct 21, 2025
@sfc-gh-aling sfc-gh-aling changed the title SNOW-2436917: fix udxf/sproc registeration regression main branch SNOW-2436917: fix udxf/sproc registeration regression Oct 21, 2025
_suppress_local_package_warnings=kwargs.get(
"_suppress_local_package_warnings", False
),
# DO NOT pass **kwargs here, as it can lead to TypeError: multiple values for the same argument
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put it here as a reminder to future developers

@sfc-gh-aling sfc-gh-aling changed the title SNOW-2436917: fix udxf/sproc registeration regression SNOW-2436917: fix udxf/sproc registration regression Oct 21, 2025
@sfc-gh-aling sfc-gh-aling merged commit 8895a30 into main Oct 21, 2025
51 of 61 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-2436917-fix-regression-main branch October 21, 2025 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants