This repository was archived by the owner on Mar 7, 2020. It is now read-only.
made 'grunt packaging' use a different tmp dir #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Closing in deference to the parent ticket |
Contributor
|
I was able to verify this issue and one solution is move the target to _dist. I'm gonna try this solution as it is more elegant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In packaging.js (line 60), the rimraf module is used to delete 'install_dir'. However 'install_dir' had been set to 'dist', which is also our final destination (in opts.dist_folder). Because the intermediate dir (install_dir) was copied into itself, the zip file would lose it's contents. And then when trying to clean up the intermediate directory, the 'dist' folder would be deleted.