Fix miscellaneous issues #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added this to get a better output from our http get/post functions - a wrapper around an "internal error code" and the actual http response Also commented out the http test for now as it depends on an external source
also some minor refactoring of httpclient, trying to sort out post requests for win
Include support for POST requests and ensure SSL/https works. Integration tags can be toggled in http_client_test.cpp.
Initial - forces to osx and runs the build steps in the readme expect it to change later. NB. There's no windows target available in travis yet.
Turned off a couple of tests as these are designed to be run locally rather than on the CI.
Using version 3.12.2
also add some more stock items to tracker.hpp/cpp
|
Thanks Simon! Can you sign one of the Snowplow CLAs please: https://github.com/snowplow/snowplow/wiki/CLA |
|
Hi @simoncl2 could you please sign one of the Snowplow CLAs? As soon as that is done we can merge this PR in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix miscellaneous issues & memory leak.