Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release golang cli on linux #4255

Merged
merged 2 commits into from Dec 22, 2022
Merged

chore: release golang cli on linux #4255

merged 2 commits into from Dec 22, 2022

Conversation

Avishagp
Copy link
Contributor

Release golang CLI on linux.
JIRA ticket

@Avishagp Avishagp requested a review from a team as a code owner December 21, 2022 11:11
PeterSchafer
PeterSchafer reviewed Dec 21, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
PeterSchafer
PeterSchafer reviewed Dec 21, 2022
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
PeterSchafer
PeterSchafer requested changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately the build doesn't run, please see my comments on how to fix it.

@Avishagp Avishagp force-pushed the chore/HMMR-567-release-golang-cli-for-linux branch from 169ca9e to bbf9c60 Compare December 21, 2022 12:29
@Avishagp Avishagp force-pushed the chore/HMMR-567-release-golang-cli-for-linux branch from bbf9c60 to 1099d59 Compare December 21, 2022 14:07
@Avishagp Avishagp force-pushed the chore/HMMR-567-release-golang-cli-for-linux branch from 1099d59 to c04a6ea Compare December 21, 2022 14:13
@PeterSchafer
Copy link
Contributor

Please also take rename/replace "snyk_linux_arm64"

@Avishagp Avishagp force-pushed the chore/HMMR-567-release-golang-cli-for-linux branch from da99665 to 974ba9b Compare December 22, 2022 11:29
@Avishagp Avishagp merged commit c22f2c6 into master Dec 22, 2022
12 checks passed
@Avishagp Avishagp deleted the chore/HMMR-567-release-golang-cli-for-linux branch December 22, 2022 14:16
PeterSchafer added a commit that referenced this pull request Dec 22, 2022
@PeterSchafer
Revert "Merge pull request #4255 from snyk/chore/HMMR-567-release-gol…
265b5ef 
…ang-cli-for-linux"

This reverts commit c22f2c6, reversing
changes made to adcdea8.
PeterSchafer added a commit that referenced this pull request Dec 22, 2022
@PeterSchafer
fix: Revert "Merge pull request #4255 from snyk/chore/HMMR-567-releas…
fb7d31e 
…e-golang-cli-for-linux"

This reverts commit c22f2c6, reversing
changes made to adcdea8.
PeterSchafer added a commit that referenced this pull request Dec 22, 2022
@PeterSchafer
Merge pull request #4258 from snyk/fix/HMMR-626_rollback
48b5d9a 
Revert "Merge pull request #4255 from snyk/chore/HMMR-567-release-gol…
@cc-prodsec cc-prodsec mentioned this pull request Jan 12, 2023
Merged
ChristinaDara pushed a commit that referenced this pull request Jan 23, 2023
@PeterSchafer @ChristinaDara
fix: Revert "Merge pull request #4255 from snyk/chore/HMMR-567-releas…
2abfcb4 
…e-golang-cli-for-linux"

This reverts commit c22f2c6, reversing
changes made to adcdea8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSchafer PeterSchafer PeterSchafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Avishagp @PeterSchafer