Skip to content

Conversation

@gitphill
Copy link
Contributor

@gitphill gitphill commented Dec 9, 2024

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

Changes dependency JSON output for snyk test and snyk container test. When using either --json or --json-file-output together with --print-deps attached a depGraph property to the output JSON.

Previously using --json and --print-deps together would produce invalid JSON.

Prevent any warning logs from invalidating JSON output when --json is being used.

Where should the reviewer start?

How should this be manually tested?

@gitphill gitphill self-assigned this Dec 9, 2024
Changes dependency JSON output for snyk test and snyk container test.
When using either `--json` or `--json-file-output` together with
`--print-deps` attached a `depGraph` property to the output JSON.

Previously using `--json` and `--print-deps` together would produce
invalid JSON.

Prevent any warning logs from invalidating JSON output when `--json`
is being used.
@gitphill gitphill force-pushed the feat/dep-graph-json-output branch from 3d7c9ec to 218b804 Compare December 16, 2024 13:07
@github-actions
Copy link
Contributor

Your PR has not had any activity for 30 days. In 2 days I'll close it. Make some activity to remove this.

@github-actions github-actions bot added the Stale label Mar 25, 2025
@github-actions
Copy link
Contributor

Your PR has now been stale for 2 days. I'm closing it.

@github-actions github-actions bot closed this Mar 30, 2025
@github-actions github-actions bot deleted the feat/dep-graph-json-output branch March 30, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants