Skip to content

Conversation

@j-luong
Copy link
Contributor

@j-luong j-luong commented Jan 23, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

This PR fixes two issues related to .snyk ignores created via the snyk ignore command:

  • ignores that included a reason and/or expiry are now being ignored as expected
  • ignores that used an absolute path instead of a relative path are now being ignored as expected

Where should the reviewer start?

How should this be manually tested?

In a project with Snyk Code issues:

  • Create ignore with a valid expiry
    • snyk ignore --expiry=3026-1-1 --reason="testing" --file-path=<absolute/path/to/file>
    • Run snyk code test
    • Validate ignored file is ignored
  • Create an expired ignore
    • snyk ignore --expiry=1999-1-1 --reason="testing" --file-path=<absolute/path/to/file>
    • Run snyk code test
    • Validate ignored file is not ignored

What's the product update that needs to be communicated to CLI users?

Ignores created via the snyk ignore command are now correctly applied if an expiry is set or if using an absolute filepath

@j-luong j-luong requested review from a team as code owners January 23, 2026 12:54
@j-luong j-luong force-pushed the fix/cli-1308_dotSnykExcludeRules branch 2 times, most recently from 2b92d82 to 07df597 Compare January 28, 2026 12:15
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code-user-journey.spec.ts

Generated by 🚫 dangerJS against a61589c

@j-luong j-luong force-pushed the fix/cli-1308_dotSnykExcludeRules branch from 07df597 to 2b1e8dd Compare January 28, 2026 13:30
@j-luong j-luong force-pushed the fix/cli-1308_dotSnykExcludeRules branch 3 times, most recently from 7c83228 to 4e1992b Compare January 29, 2026 13:28
@j-luong j-luong force-pushed the fix/cli-1308_dotSnykExcludeRules branch 2 times, most recently from b99abdd to 7e127bc Compare January 29, 2026 13:50
@j-luong j-luong force-pushed the fix/cli-1308_dotSnykExcludeRules branch from 7e127bc to a61589c Compare January 30, 2026 09:28
@PeterSchafer PeterSchafer merged commit 2cfd68f into main Jan 30, 2026
6 checks passed
@PeterSchafer PeterSchafer deleted the fix/cli-1308_dotSnykExcludeRules branch January 30, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants