feat: Removes the useImprovedDotnetWithoutRestore flag

[calhar-snyk]

Pull Request Submission Checklist

• Follows CONTRIBUTING guidelines
• Commit messages
  are release-note ready, emphasizing
  what was changed, not how.
• Includes detailed description of changes
• Contains risk assessment (Low)
• Highlights breaking API changes (if applicable)
• Links to automated tests covering new functionality
• Includes manual testing instructions (if necessary)
• Updates relevant GitBook documentation (PR link: ___)
• Includes product update to be announced in the next stable release notes

What does this PR do?

snyk-nuget-plugin@4.1.0 removed the option useImprovedDotnetWithoutPublish and treated the setting as true after a staged rollout completed.
This option was removed in snyk/snyk-nuget-plugin#280
The version of snyk-nuget-plugin got bumped in this project to v4.1.1 here: #6560

How should this be manually tested?

• Can build the legacy CLI and test any dotnet project having run dotnet restore using snyk test --dotnet-runtime-resolution
  e.g.:

❯ ls
dotnet_8.csproj           foo.json                  program.cs
expected_depgraph-v3.json obj
❯ snyk test --dotnet-runtime-resolution --print-graph --org=********
Snip

❯ ls
bin                       expected_depgraph-v3.json obj
dotnet_8.csproj           foo.json                  program.cs
❯ rm -rf bin
❯ ~/code/cli/bin/snyk test --dotnet-runtime-resolution --print-graph --org=********
Snip

❯ ls
dotnet_8.csproj           foo.json                  program.cs
expected_depgraph-v3.json obj

Note how the current invocation builds the bin folder, while the newly built cli does not.

Any background context you want to provide?

useImprovedDotnetWithoutPublish was a flag that could be passed to the snyk-nuget-plugin which would affect the behaviour of the --dotnet-runtime-resolution flag.
Previously, --dotnet-runtime-resolution would cause the snyk-nuget-plugin to run dotnet publish ... under the hood in order to get runtime dependencies. However, this is expensive -- useImprovedDotnetWithoutPublish was an internal feature flag to trial and rollout a mechanism of detecting runtime resolutions without the use of dotnet publish ...

What are the relevant tickets?

• OSE-214 -- Removal ticket
• OSE-119 -- Previous rollout ticket

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[snyk-pr-review-bot]

PR Reviewer Guide 🔍

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

📚 Repository Context Analyzed This review considered 12 relevant code sections from 9 files (average relevance: 0.90) cliv2/cmd/cliv2/main.go (2 segments, lines 86-730) scripts/build-ts-binary-wrapper-locally.go (lines 1-261) src/cli/commands/constants.ts (lines 1-13) src/cli/main.ts (lines 1-516) help/cli-commands/test.md (2 segments, lines 1-100) package-lock.json (lines 1-100) help/cli-commands/monitor.md (2 segments, lines 1-100) ... and 2 more file(s)