Skip to content

fix: ensure --json-file-output does not write to stdout#6580

Merged
CatalinSnyk merged 1 commit intomainfrom
chore/cli-1353_fix_writer_file_output
Mar 3, 2026
Merged

fix: ensure --json-file-output does not write to stdout#6580
CatalinSnyk merged 1 commit intomainfrom
chore/cli-1353_fix_writer_file_output

Conversation

@CatalinSnyk
Copy link
Copy Markdown
Contributor

@CatalinSnyk CatalinSnyk commented Feb 24, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Update the GAF dependency to introduce a fix related to the output_workflow behaviour. Previously, in certain cases, JSON output would get printed to stdout when only the --json-file-output parameter was used.

Where should the reviewer start?

How should this be manually tested?

Compare the stdout output for the command snyk sbom --format cyclonedx1.6+json --json-file-output=sbom.json. Before this changes the content would also be printed on stdout.

What's the product update that needs to be communicated to CLI users?

Fixes a bug where the JSON file output would be printed on stdout.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 24, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 24, 2026

Warnings
⚠️

"fix: don't output JSON for other workflow data when JSON file output is set" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 32f65f0

@CatalinSnyk CatalinSnyk changed the title fix: don't output JSON for other workflow data when JSON file output … fix: don't output JSON for other workflow data when JSON file is set Feb 24, 2026
@CatalinSnyk CatalinSnyk changed the title fix: don't output JSON for other workflow data when JSON file is set fix: ensure --json-file-output writes does not write to stdout Feb 24, 2026
@CatalinSnyk CatalinSnyk changed the title fix: ensure --json-file-output writes does not write to stdout fix: ensure --json-file-output does not write to stdout Feb 24, 2026
@CatalinSnyk CatalinSnyk force-pushed the chore/cli-1353_fix_writer_file_output branch 7 times, most recently from 36b5c0d to 6a6f71d Compare March 2, 2026 14:21
@CatalinSnyk CatalinSnyk marked this pull request as ready for review March 2, 2026 14:23
@CatalinSnyk CatalinSnyk requested review from a team as code owners March 2, 2026 14:23
@CatalinSnyk CatalinSnyk enabled auto-merge March 2, 2026 14:23
@CatalinSnyk CatalinSnyk force-pushed the chore/cli-1353_fix_writer_file_output branch from 6a6f71d to 32f65f0 Compare March 3, 2026 08:25
@CatalinSnyk CatalinSnyk merged commit b6f30ce into main Mar 3, 2026
8 checks passed
@CatalinSnyk CatalinSnyk deleted the chore/cli-1353_fix_writer_file_output branch March 3, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants