Skip to content

fix: check stderr for json errors in TS -> Go call#6641

Merged
thomasschafer merged 1 commit intomainfrom
fix/render-errors-from-stderr
Mar 17, 2026
Merged

fix: check stderr for json errors in TS -> Go call#6641
thomasschafer merged 1 commit intomainfrom
fix/render-errors-from-stderr

Conversation

@thomasschafer
Copy link
Contributor

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High) - n/a
  • Highlights breaking API changes (if applicable) - n/a
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___) - n/a
  • Includes product update to be announced in the next stable release notes - n/a

What does this PR do?

Previously in the TS -> Go call performed by the uv plugin, JSON errors were assumed to be on stdout. However, from some testing they appear to be written to stderr, at least in the tests I've performed. This PR updates the error handling to check both sources.

How should this be manually tested?

In a uv project, add or remove a dependency in the pyproject.toml without updating the uv.lock. If you then run snyk monitor you should see the following error:

Monitoring <path/to/uv/project>...

{
  "ok": false,
  "error": "uv.lock is out of sync with pyproject.toml. Run `uv lock` to update the lockfile, or re-run with `--strict-out-of-sync=false` to test the outdated lockfile regardless.",
  "path": "/Users/thomasschafer/Development/Work/uv-goof/workspace"
}

On this branch you should instead see:

Monitoring <path/to/uv/project>...

uv.lock is out of sync with pyproject.toml. Run `uv lock` to update the lockfile, or re-run with `--strict-out-of-sync=false` to test the outdated lockfile regardless.

What's the product update that needs to be communicated to CLI users?

None

@snyk-io
Copy link

snyk-io bot commented Mar 13, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2026

Warnings
⚠️

You've modified files in src/ directory, but haven't updated anything in test folder. Is there something that could be tested?

Generated by 🚫 dangerJS against 30aa63c

@thomasschafer thomasschafer force-pushed the fix/render-errors-from-stderr branch 2 times, most recently from 1df523a to 7786c13 Compare March 13, 2026 17:02
@thomasschafer thomasschafer marked this pull request as ready for review March 13, 2026 17:03
@thomasschafer thomasschafer requested review from a team as code owners March 13, 2026 17:03
@snyk-pr-review-bot

This comment has been minimized.

@thomasschafer thomasschafer force-pushed the fix/render-errors-from-stderr branch from 7786c13 to 248683e Compare March 16, 2026 10:44
@snyk-pr-review-bot

This comment has been minimized.

@thomasschafer thomasschafer force-pushed the fix/render-errors-from-stderr branch from 248683e to 4364873 Compare March 16, 2026 12:19
@snyk-pr-review-bot

This comment has been minimized.

@thomasschafer thomasschafer force-pushed the fix/render-errors-from-stderr branch from 4364873 to 0b49122 Compare March 17, 2026 10:18
@thomasschafer thomasschafer enabled auto-merge March 17, 2026 10:18
@snyk-pr-review-bot

This comment has been minimized.

@thomasschafer thomasschafer force-pushed the fix/render-errors-from-stderr branch from 0b49122 to 30aa63c Compare March 17, 2026 12:39
@snyk-pr-review-bot
Copy link

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected
📚 Repository Context Analyzed

This review considered 3 relevant code sections from 3 files (average relevance: 1.03)

@thomasschafer thomasschafer merged commit 5e92d1b into main Mar 17, 2026
9 checks passed
@thomasschafer thomasschafer deleted the fix/render-errors-from-stderr branch March 17, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants