Skip to content

fix: evaluate Go plugin feature flags early#6645

Merged
mcombuechen merged 1 commit intomainfrom
fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point
Mar 18, 2026
Merged

fix: evaluate Go plugin feature flags early#6645
mcombuechen merged 1 commit intomainfrom
fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point

Conversation

@tonidevine1
Copy link
Contributor

@tonidevine1 tonidevine1 commented Mar 13, 2026

What does this PR do?

Evaluates the includeGoStandardLibraryDeps and disableGoPackageUrlsInCli feature flags at the command entry points (test, monitor) instead of evaluating at the individual plugin level. This aligns with the existing pattern used by other feature flags (e.g. hasPnpmSupport) where they resolve once at the command entry point. In the current stable release, this causes exceedingly large amounts of traffic to FF endpoints and added latency for use cases with many Go projects (--all-projects).

@snyk-io
Copy link

snyk-io bot commented Mar 13, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@tonidevine1 tonidevine1 force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from ecaa806 to df1215b Compare March 13, 2026 15:11
@tonidevine1 tonidevine1 reopened this Mar 13, 2026
@tonidevine1 tonidevine1 force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from df1215b to ed8d718 Compare March 13, 2026 15:25
@tonidevine1 tonidevine1 self-assigned this Mar 13, 2026
@tonidevine1 tonidevine1 force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from ed8d718 to e2c9b44 Compare March 13, 2026 15:38
@mcombuechen mcombuechen marked this pull request as ready for review March 16, 2026 15:33
@mcombuechen mcombuechen requested review from a team as code owners March 16, 2026 15:33
@mcombuechen mcombuechen force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from 84eb482 to 89b2278 Compare March 16, 2026 15:34
@snyk-pr-review-bot

This comment has been minimized.

@snyk-pr-review-bot

This comment has been minimized.

@mcombuechen mcombuechen changed the title fix: ff envaluation for includeGoStandardLibraryDeps fix: evaluate Go plugin feature flags early Mar 16, 2026
@mcombuechen mcombuechen force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from 89b2278 to 13ad299 Compare March 17, 2026 16:33
@snyk-pr-review-bot

This comment has been minimized.

@mcombuechen mcombuechen enabled auto-merge March 18, 2026 07:21
Co-Authored-By: Max <max.combuchen@snyk.io>
@mcombuechen mcombuechen force-pushed the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch from 13ad299 to f2f5ba2 Compare March 18, 2026 07:22
@snyk-pr-review-bot
Copy link

PR Reviewer Guide 🔍

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Interface Mismatch 🟠 [major]

Properties includeGoStandardLibraryDeps and includePackageUrls were removed from the configuration object in the Options interface. However, these properties are still being explicitly assigned in src/lib/plugins/build-plugin-options.ts (lines 24-29) and the resulting object is cast to the updated (and now restricted) Options['configuration'] type. This will result in TypeScript compilation errors ("Property '...' does not exist on type '...'") when the CLI is built, as the compiler can no longer find these keys in the interface definition.

configuration?: {
  // Used only with the Go plugin.
  // TODO: remove once UNIFY-891 is done.
  useReplaceName?: boolean;
};
📚 Repository Context Analyzed

This review considered 22 relevant code sections from 12 files (average relevance: 1.00)

@mcombuechen mcombuechen merged commit a6a0e99 into main Mar 18, 2026
9 checks passed
@mcombuechen mcombuechen deleted the fix/includeGoStandardLibraryDeps-ff-evaluate-at-command-entry-point branch March 18, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants