Skip to content

fix(ci): check-dependecies gh action now uses npm token to access private packages#6813

Merged
j-luong merged 1 commit into
mainfrom
fix(ci)/cli-1513_fixCheckDependenciesAction
May 15, 2026
Merged

fix(ci): check-dependecies gh action now uses npm token to access private packages#6813
j-luong merged 1 commit into
mainfrom
fix(ci)/cli-1513_fixCheckDependenciesAction

Conversation

@j-luong
Copy link
Copy Markdown
Contributor

@j-luong j-luong commented May 15, 2026

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Fixes the GitHub Action workflow check-dependencies.yml and danger-zone.yml so that it can access private packages.

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

None - internal fix

@j-luong j-luong marked this pull request as ready for review May 15, 2026 13:51
@j-luong j-luong requested review from a team as code owners May 15, 2026 13:51
@j-luong j-luong enabled auto-merge May 15, 2026 13:51
@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented May 15, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@snyk-pr-review-bot

This comment has been minimized.

@j-luong j-luong force-pushed the fix(ci)/cli-1513_fixCheckDependenciesAction branch from 479c165 to 83b84c4 Compare May 15, 2026 13:58
@snyk-pr-review-bot

This comment has been minimized.

Copy link
Copy Markdown

@robertolopezlopez robertolopezlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-luong j-luong force-pushed the fix(ci)/cli-1513_fixCheckDependenciesAction branch from 83b84c4 to 3511a3d Compare May 15, 2026 14:00
@github-actions
Copy link
Copy Markdown
Contributor

Warnings
⚠️

"fix(ci): check-dependecies gh action now uses npm token to access private packages" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 3511a3d

@snyk-pr-review-bot
Copy link
Copy Markdown

PR Reviewer Guide 🔍

🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Workflow Scope Error (2 occurrences) 🟠 [major]
  1. .github/workflows/check-dependencies.yml
    The NODE_AUTH_TOKEN environment variable is only provided to the npm ci step. However, the addition of registry-url to setup-node configures the runner's .npmrc to use ${NODE_AUTH_TOKEN} for all subsequent commands. The next step, npx ts-node ./scripts/check-dependencies.ts, will likely fail when npm (invoked by npx) attempts to parse the global .npmrc and finds the environment variable missing or empty. This variable should be defined at the job level or repeated for the script step.

  2. .github/workflows/danger-zone.yml
    Similar to the check-dependencies workflow, the Danger JS job now configures a registry that requires NODE_AUTH_TOKEN interpolation. The npx danger ci step lacks this environment variable in its scope. If the Danger script or npx itself triggers any registry lookups (e.g., to verify package versions), it will fail due to the unresolvable token in the .npmrc configuration.

📚 Repository Context Analyzed

This review considered 2 relevant code sections from 2 files (average relevance: 0.72)

@j-luong j-luong merged commit 1271f24 into main May 15, 2026
10 checks passed
@j-luong j-luong deleted the fix(ci)/cli-1513_fixCheckDependenciesAction branch May 15, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants