Fix acceptance test issues #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #166 +/- ##
=======================================
Coverage 69.72% 69.72%
=======================================
Files 190 190
Lines 4364 4364
=======================================
Hits 3043 3043
Misses 1081 1081
Partials 240 240 |
wbeuil
reviewed
Jan 29, 2021
doc/contributing/tests.md
Outdated
| one for terraform related actions, and one for driftctl scan. | ||
|
|
||
| You can override environment variables passed to terraform operations by adding `ACC_` prefix on env variables. | ||
| Environment used in `PreCheck()` is using using overriden env too as it is common to perform mutations in that place. |
Contributor
There was a problem hiding this comment.
I don't understand your sentence here, can you help me get it in order to rephrase it well.
Contributor
There was a problem hiding this comment.
In our acceptance tests, we may need read/write permissions during specific contexts (e.g. terraform init, apply, destroy) or lifecycle (PreExec and PostExec). If needed, you can override environment variables in those contexts by adding ACC_ prefix on env variables.
Contributor
Author
There was a problem hiding this comment.
This is a way better, fixed
eliecharra
force-pushed
the
acc_test_fixes
branch
from
daccc8c to
81c5ba8
Compare
- Set all test AZ to us-east-1 - Use terraform overriden env in PreCheck() to ensure mutations are executed with read write credentials - Fix hidden error in aws_instance test (tag creation failure was not handled - Minor fmt fix
eliecharra
force-pushed
the
acc_test_fixes
branch
from
d6ac6ca to
f06a426
Compare
wbeuil
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PreCheck()to ensure mutations are executed with read write credentials