Skip to content

Conversation

@eliecharra
Copy link
Contributor

Q A
πŸ› Bug fix? yes
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #...
❓ Documentation no

Description

References

@eliecharra eliecharra added the kind/bug Something isn't working label Feb 4, 2021
@eliecharra eliecharra requested a review from a team February 4, 2021 21:44
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #208 (5b9b70c) into main (978b6a1) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   69.58%   69.72%   +0.13%     
==========================================
  Files         206      206              
  Lines        4613     4634      +21     
==========================================
+ Hits         3210     3231      +21     
  Misses       1146     1146              
  Partials      257      257              
Impacted Files Coverage Ξ”
pkg/remote/aws/ec2_eip_association_supplier.go 69.69% <100.00%> (+0.94%) ⬆️
pkg/remote/aws/iam_role_policy_supplier.go 74.46% <100.00%> (+1.13%) ⬆️
pkg/remote/aws/vpc_security_group_rule_supplier.go 84.92% <100.00%> (+0.12%) ⬆️
...ource/aws/deserializer/db_instance_deserializer.go 76.47% <100.00%> (+1.47%) ⬆️
...e/aws/deserializer/db_subnet_group_deserializer.go 64.28% <100.00%> (+2.74%) ⬆️
...s/deserializer/default_route_table_deserializer.go 56.25% <100.00%> (+2.91%) ⬆️
...eserializer/default_security_group_deserializer.go 64.28% <100.00%> (+2.74%) ⬆️
...ce/aws/deserializer/default_subnet_deserializer.go 64.28% <100.00%> (+2.74%) ⬆️
...ource/aws/deserializer/default_vpc_deserializer.go 64.28% <100.00%> (+2.74%) ⬆️
.../aws/deserializer/internet_gateway_deserializer.go 56.25% <100.00%> (+2.91%) ⬆️
... and 10 more

@eliecharra eliecharra force-pushed the fix_loop_scope_issues branch from 962e9f8 to 5b9b70c Compare February 4, 2021 21:45
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog to learn small tips ! Thanks

@eliecharra eliecharra merged commit a5296e4 into main Feb 5, 2021
@eliecharra eliecharra deleted the fix_loop_scope_issues branch February 5, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants