Replace manual terraform execution with hashicorp/terraform-exec #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to snyk#119 Signed-off-by: sshota0809 <8736380+sshota0809@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
=======================================
Coverage 69.81% 69.81%
=======================================
Files 211 211
Lines 4740 4740
=======================================
Hits 3309 3309
Misses 1166 1166
Partials 265 265 |
eliecharra
reviewed
Feb 5, 2021
Contributor
eliecharra
left a comment
eliecharra
left a comment
There was a problem hiding this comment.
That look awesome, nothing to say 👍🏻
I tried locally and it seems that terraform apply errors are displayed twice, could you investigate ?
Contributor
|
Hmm it seems to be an issue with my IDE (Goland), when running test with
|
Contributor
Author
|
@eliecharra |
Contributor
let me rather investigate this on my side. I'll keep you informed |
eliecharra
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm done with replacing manual terraform execution with hashicorp/terraform-exec
Please review my commits!