Skip to content

Update to go 1.16 #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eliecharra merged 2 commits into from
Feb 18, 2021
Merged

Update to go 1.16 #268

eliecharra merged 2 commits into from
Feb 18, 2021

Conversation

@eliecharra
Copy link
Contributor

@eliecharra eliecharra commented Feb 17, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? yes
⚠ Deprecations? no
❌ BC Break no
πŸ”— Related issues #66
❓ Documentation no

Description

  • Update to go 1.16
  • Add support for Apple sillicon

@eliecharra eliecharra added the kind/enhancement New feature or improvement label Feb 17, 2021
@eliecharra eliecharra added this to the v0.5.0 milestone Feb 17, 2021
@eliecharra eliecharra requested a review from a team February 17, 2021 09:02
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #268 (0c06dfa) into main (735337a) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   69.07%   69.05%   -0.03%     
==========================================
  Files         240      240              
  Lines        5241     5244       +3     
==========================================
+ Hits         3620     3621       +1     
- Misses       1325     1326       +1     
- Partials      296      297       +1
Impacted Files Coverage Ξ”
pkg/terraform/provider_config.go 86.66% <50.00%> (-13.34%) ⬇️

lotoussa
lotoussa previously approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's build faster !

wbeuil
wbeuil previously approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@wbeuil wbeuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with that. Just i would wait for @sjourdan to test a dev/release build with a real M1.

@eliecharra eliecharra dismissed stale reviews from wbeuil and lotoussa via db34309 February 18, 2021 09:16
@eliecharra
Copy link
Contributor Author

eliecharra commented Feb 18, 2021

I'm good with that. Just i would wait for @sjourdan to test a dev/release build with a real M1.

image

@eliecharra eliecharra merged commit 82ee3cd into main Feb 18, 2021
@eliecharra eliecharra deleted the go1.16 branch February 18, 2021 14:08
@eliecharra eliecharra linked an issue Feb 18, 2021 that may be closed by this pull request
Apple Silicon M1 (ARM) Build #66
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@moadibfr moadibfr moadibfr approved these changes

@wbeuil wbeuil wbeuil left review comments

@lotoussa lotoussa lotoussa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement New feature or improvement

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

Apple Silicon M1 (ARM) Build

5 participants

@eliecharra @moadibfr @wbeuil @lotoussa