Skip to content

Conversation

@lotoussa
Copy link
Contributor

@lotoussa lotoussa commented Mar 26, 2021

Q A
πŸ› Bug fix? no
πŸš€ New feature? no
⚠ Deprecations? no
❌ BC Break yes
πŸ”— Related issues #367
❓ Documentation no

Description

The error reporting flag seems to be confusing.
We need to make it clear that is sends some data to out Sentry server.

So i add an information i found on driftctl-docs error-reporting part to the helper message of the program.

@lotoussa lotoussa added kind/documentation Improvements or additions to documentation next-version/patch labels Mar 26, 2021
@lotoussa lotoussa requested a review from a team as a code owner March 26, 2021 16:36
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #381 (85d0ba8) into v0.7 (f34d544) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             v0.7     #381      +/-   ##
==========================================
+ Coverage   69.44%   69.46%   +0.01%     
==========================================
  Files         281      281              
  Lines        6016     6016              
==========================================
+ Hits         4178     4179       +1     
  Misses       1486     1486              
+ Partials      352      351       -1     
Impacted Files Coverage Ξ”
pkg/cmd/driftctl.go 81.63% <100.00%> (+2.04%) ⬆️

@lotoussa lotoussa force-pushed the issue_367_lotoussa branch from 93053c6 to 85d0ba8 Compare March 29, 2021 10:56
@eliecharra eliecharra merged commit a8a3d6c into v0.7 Mar 29, 2021
@eliecharra eliecharra deleted the issue_367_lotoussa branch March 29, 2021 12:32
@sundowndev sundowndev mentioned this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants