Fix aws_route53_record error when deserializing resource (null value is not allowed) #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotoussa
force-pushed
the
issue_375_lotoussa
branch
from
aa43b0e to
77dd846
Compare
Codecov Report
@@ Coverage Diff @@
## v0.7 #401 +/- ##
==========================================
- Coverage 69.49% 69.42% -0.07%
==========================================
Files 281 281
Lines 6026 6032 +6
==========================================
Hits 4188 4188
- Misses 1487 1491 +4
- Partials 351 353 +2
|
eliecharra
approved these changes
Mar 31, 2021
Contributor
eliecharra
left a comment
eliecharra
left a comment
There was a problem hiding this comment.
LGTM but be careful to keep your PR minimalist.
The typo fix in pkg/middlewares/route53_records_test.go is not related to this bug
Contributor
|
You need to rebase your PR onto branch |
sundowndev
approved these changes
Mar 31, 2021
wbeuil
suggested changes
Apr 1, 2021
lotoussa
force-pushed
the
issue_375_lotoussa
branch
from
0eb6713 to
816261e
Compare
β¦rash when it's null
lotoussa
force-pushed
the
issue_375_lotoussa
branch
from
816261e to
70b1cae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Everything is in the #375 ticket.
We have also fixed new false positive.