Create driftignore generator command#433
Merged
sundowndev merged 2 commits intov0.8from May 4, 2021
Merged
Conversation
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
from
bb9ca22 to
874a0fb
Compare
Codecov Report
@@ Coverage Diff @@
## v0.8 #433 +/- ##
==========================================
+ Coverage 70.76% 70.98% +0.21%
==========================================
Files 287 288 +1
Lines 6496 6545 +49
==========================================
+ Hits 4597 4646 +49
Misses 1522 1522
Partials 377 377
|
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
4 times, most recently
from
e706f8c to
31faf3a
Compare
Contributor
|
To rebase on |
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
2 times, most recently
from
30d5ecd to
563ef04
Compare
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
2 times, most recently
from
6cda13a to
f7b513b
Compare
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
2 times, most recently
from
79436ed to
8a8bbb6
Compare
Closed
eliecharra
suggested changes
Apr 30, 2021
Contributor
eliecharra
left a comment
eliecharra
left a comment
There was a problem hiding this comment.
Maybe it could be usefull to introduce a --force flag to overwrite an existing .driftignore file too.
This was referenced May 3, 2021
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
2 times, most recently
from
f6059a2 to
7033d7e
Compare
eliecharra
suggested changes
May 4, 2021
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| const DriftIgnoreFilename = ".driftignore" |
Contributor
There was a problem hiding this comment.
This exported const is not required anymore
sundowndev
force-pushed
the
feat/genDriftIgnore
branch
from
73f303a to
fd563fd
Compare
This was referenced May 5, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: The purpose of this change is to be able to generate a .driftignore file containing current drifts.
Context
New users can struggle when trying the tool because the output is too large and hard to read. They might want to ignore all the current drifts so they can start introduce the tool in their workflow quickly and fix the current issues later. This feature allows them to create a driftignore file from a JSON output.
Flags
--exclude-unmanagedallows to control whether unmanaged resources are included or not--exclude-missingallows to control whether missing resources are included or not--exclude-changedallows to control whether changed resources are included or notExamples