feat: resolve quote-token seeds via vault refs#69
Merged
rickcrawford merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
656be51 to
53868d3
Compare
Allow quote-token and ledger secret refs to use sbproxy-vault secret references with environment fallback while preserving existing env and inline paths. Co-authored-by: Cursor <cursoragent@cursor.com>
53868d3 to
a384c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
secret_refto accept{ secret: "..." }in addition to{ env: "..." }.secret:references throughsbproxy-vault::SecretResolverwith env fallback for OSS/dev parity.Test plan
cargo test -p sbproxy-modules quote_token_yaml_resolves_secret_ref_secret_via_env_fallbackfailed with missingenvcargo test -p sbproxy-modules quote_token_yaml_resolves_secret_ref_secret_via_env_fallbackcargo test -p sbproxy-modules ledger_yaml_block_resolves_secret_ref_envcargo check -p sbproxy-modulescargo fmt --all -- --checkgit diff --checkMade with Cursor