Enable connector fallback for ADC/PWM provisioning in Arduino-index mode#12
Closed
Copilot wants to merge 5 commits intoconfigure_by_connector_deffrom
Closed
Conversation
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update connector definition configuration based on feedback
Decouple ADC/PWM provisioning from pin association
Feb 11, 2026
Owner
|
@copilot digital_pin_gpiosがある場合とない場合でルールが異なります。io-channels の有無は最終的にBUILD_ASSERTでチェックされます。修正を。 |
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Author
Fixed in commit e2cf6d7. Added connector fallback within the
BUILD_ASSERT continues to validate that provisioning and association arrays match in size. |
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Copilot
AI
changed the title
Decouple ADC/PWM provisioning from pin association
Enable connector fallback for ADC/PWM provisioning in Arduino-index mode
Feb 11, 2026
Owner
|
@copilot TODOを実装してください。 |
Copilot stopped work on behalf of
soburi due to an error
February 11, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADC/PWM provisioning incorrectly skipped connector
io-channel-map/pwm-mapfallback when/zephyr,user/adc-pin-gpios/pwm-pin-gpioswas present withdigital_pin_gpios, leaving arrays empty when explicit channel lists were absent. The issue was that the code didn't allow connector fallback within Arduino-index mode.Changes
Added
#elif defined(ZARD_*_CONNECTOR)fallback branches within thedigital_pin_gpiosconditional blocks for:arduino_adc[],channel_cfg[]): Checkio-channels→ connectorio-channel-maparduino_pwm[]): Checkpwms→ connectorpwm-mapThis enables connector fallback when
*-pin-gpios+digital_pin_gpiosexist but explicit channel lists are absent, while maintaining BUILD_ASSERT validation that provisioning and association arrays match in size.Before
After
Logic Flow
When
*-pin-gpios+digital_pin_gpiosexist (Arduino-index mode):io-channels/pwms) firstWhen
*-pin-gpiosexists withoutdigital_pin_gpios(global GPIO mode):When
*-pin-gpiosdoesn't exist:Aligns with
configuration-reference.md: connector maps provision channels when explicit channel lists are absent, while respecting the different rules for Arduino-index vs global GPIO numbering modes.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.