Fix PWM_PINS macro compilation without digital-pin-gpios#9
Closed
Copilot wants to merge 7 commits intoconfigure_by_connector_deffrom
Closed
Fix PWM_PINS macro compilation without digital-pin-gpios#9Copilot wants to merge 7 commits intoconfigure_by_connector_deffrom
Copilot wants to merge 7 commits intoconfigure_by_connector_deffrom
Conversation
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback from review on Configure by connector def PR
Fix PWM_PINS macro compilation without digital-pin-gpios
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PWM_PINSmacro unconditionally usesDIGITAL_PIN_GPIOS_FIND_PIN, which is only defined when/zephyr,user/digital-pin-gpiosexists. Boards using global GPIO numbering withpwm-pin-gpiosbut nodigital-pin-gpiosfail to compile.Changes:
PWM_PINSmacro incores/arduino/zephyrCommon.cpp:digital_pin_gpiosexists: useDIGITAL_PIN_GPIOS_FIND_PIN(existing behavior)digital_pin_gpiosabsent: useZARD_GLOBAL_GPIO_NUMto compute global GPIO numbersThis mirrors the pattern already used for ADC pins in
Arduino.h(lines 159-170).💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.