Add wallet connection stall detection and ad-blocker hint#2
Merged
sochima2 merged 1 commit intoMay 31, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
useConnect/reconnect flows to hang with no error, leading to confused users and support requests.Description
useWalletConnectionStallDetectionhook insrc/hooks/useWalletConnectionStallDetection.tswith a named timeout constantWALLET_CONNECTION_STALL_TIMEOUT_MSand shared messageWALLET_CONNECTION_AD_BLOCKER_MESSAGE.ConnectWalletButtonandWalletConnectCalloutBannerso the ad-blocker suggestion appears only when a wallet connection/reconnect remains pending past the timeout and is cleared when the attempt succeeds or fails.src/hooks/__tests__/useWalletConnectionStallDetection.test.tscovering the stalled, success-before-timeout, and failure-before-timeout behaviors.Testing
pnpm exec vitest run src/hooks/__tests__/useWalletConnectionStallDetection.test.ts, and the new tests passed.pnpm lintandpnpm build, both completed successfully.pnpm testinvocation that ran the full suite surfaced pre-existing unrelated failures (missing test deps and unrelated assertions) which are not caused by this change.Codex Task