Feat: Add project manual save and auto-save before export (Closes #12)#23
Conversation
- Add "Save" button to the composer ExportBar. - Auto-save current project to IndexedDB before WebM export. - Update tests to verify auto-save triggers when Export and Save are clicked. - Add @eslint/js dependency to resolve flat-config parsing errors. Co-authored-by: socialawy <24765060+socialawy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
✅ Gemini Review: APPROVE (Risk: low) The PR successfully adds manual save and auto-save before export functionality to the ExportBar component. The changes are well-tested, handle state correctly, and properly integrate with the existing export flow. The addition of the missing ESLint dependency resolves CI issues without introducing breaking changes. Automated review by Gemini 3.1 Pro |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
- Add "Save" button to the composer ExportBar. - Auto-save current project to IndexedDB before WebM export. - Update tests to verify auto-save triggers when Export and Save are clicked. - Add @eslint/js dependency to resolve flat-config parsing errors. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: socialawy <24765060+socialawy@users.noreply.github.com>
1 participant
This PR implements the missing persistence feature requested in issue #12.
Changes
ExportBarcomponent that directly triggers thesaveNowfunction from theprojectstore. It disabled itself appropriately when there are no plates.ExportBarto awaitsaveNowbefore beginning export, ensuring no work is lost if the export crashes or hangs.tests/composer/ExportBar.test.tsx) to verify the click behaviors and ensuresaveNowis called at the correct times.@eslint/jsdevDependency to fix the CI pipeline lint failures caused by recent dependabot bumps to ESLint v10.PR created automatically by Jules for task 3364169354171303295 started by @socialawy