Merged
Conversation
ritosilva
requested changes
Apr 18, 2025
Contributor
ritosilva
left a comment
ritosilva
left a comment
There was a problem hiding this comment.
I could not read in the code where the behaviour values are used.
|
|
||
| def setup() { | ||
| given: | ||
| 'load behaviour directory' |
| def setup() { | ||
| given: | ||
| 'load behaviour directory' | ||
| def mavenBaseDir = System.getProperty("maven.basedir", new File(".").absolutePath) |
Contributor
There was a problem hiding this comment.
define "maven.basedir" as a constant in a superclass
| 'load behaviour directory' | ||
| def mavenBaseDir = System.getProperty("maven.basedir", new File(".").absolutePath) | ||
| behaviourService.LoadDir(mavenBaseDir, "groovy/" + this.class.simpleName) | ||
|
|
Contributor
There was a problem hiding this comment.
Actually, these two lines can be in an reusable method in a superclass
|
|
||
| def setup() { | ||
| given: | ||
| 'load behaviour directory' |
Contributor
There was a problem hiding this comment.
better name is given: "a behavior specification"
| and: 'a tournament where the first user is the creator' | ||
| tournamentDto = createTournament(TIME_1, TIME_3, 2, userCreatorDto.getAggregateId(), courseExecutionDto.getAggregateId(), [topicDto1.getAggregateId(),topicDto2.getAggregateId()]) | ||
|
|
||
| and: 'two units of work' |
Contributor
There was a problem hiding this comment.
Actually are two functionality instances
| } | ||
| } | ||
|
|
||
|
|
| throw new IllegalArgumentException("Step with name: " + stepName + " not found."); | ||
| } | ||
| } No newline at end of file | ||
|
|
|
|
||
|
|
||
| } | ||
|
|
| private static BehaviourHandler instance; | ||
| private static Map<String, Integer> funcCounter = new HashMap<>(); | ||
| private static String directory; | ||
| private static String ReportFile = "BehaviourReport.txt"; |
|
|
||
| try { | ||
| return executionPlan.execute(unitOfWork) | ||
|
|
Contributor
There was a problem hiding this comment.
The changes in this file look just like formatting
ritosilva
reviewed
Apr 29, 2025
Contributor
ritosilva
left a comment
ritosilva
left a comment
There was a problem hiding this comment.
tcc tests are not working
ritosilva
requested changes
Apr 29, 2025
| for (FlowStep step: plan) { | ||
| if (!this.stepFutures.containsKey(step)) { // if the step has dependencies | ||
| stepName = step.getName(); | ||
| final int faultValue = behaviour.containsKey(stepName) ? behaviour.get(stepName).get(0) : 0; |
Contributor
There was a problem hiding this comment.
What does 0 mean? NOT_FAULT?
ritosilva
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.