Skip to content

AMPR-165 #489: Finish declarative spark migration#491

Merged
wow-miley merged 2 commits into
mainfrom
wow-miley/migrate-role-sparks
May 18, 2026
Merged

AMPR-165 #489: Finish declarative spark migration#491
wow-miley merged 2 commits into
mainfrom
wow-miley/migrate-role-sparks

Conversation

@wow-miley
Copy link
Copy Markdown
Contributor

Closes #489.

This PR finishes AMPR-165 by moving the remaining role, language, and Ampere project sparks into JSON-frontmatter fixtures and removing the hard-coded RoleSpark hierarchy. It extends the spark parser/registry with role, language, and project lookup surfaces, adds sensitive-file forbiddenRefs, and wires factories/Arc spawning to resolve declarative sparks. Tests cover fixture equivalence, parser variants, registry lookup, factory fail-fast behavior, and Ampere project interpolation. Validated with ./gradlew ktlintFormat, ./gradlew jvmTest, and git diff --check.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 17, 2026

Concept staleness check — 1 warning(s).

These changes touched files listed under a concept's tracked_sources without updating the concept file. Either update the concept (and bump last_verified) or include a Concept-Verified: <ConceptName> trailer in a commit on this PR.

Validator output
⚠ Concept 'EventSerialBus' may be stale: ampere-core/src/commonMain/kotlin/link/socket/ampere/agents/domain/event/SparkEvent.kt matches tracked_sources pattern ampere-core/src/commonMain/kotlin/link/socket/ampere/agents/domain/event/** but docs/concepts/event-serial-bus.md was not modified.

validate-concepts: 1 warning(s). Validator informs; never blocks.

@wow-miley wow-miley marked this pull request as ready for review May 18, 2026 00:33
@wow-miley wow-miley merged commit 5060052 into main May 18, 2026
3 checks passed
@wow-miley wow-miley deleted the wow-miley/migrate-role-sparks branch May 18, 2026 00:33
@wow-miley wow-miley mentioned this pull request May 23, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement: JSON frontmatter for .spark.md + role spark registry

1 participant