PHO-24/#44 add CliOrb LumosRenderer<LumosTerminalFrame> terminal renderer#50
Merged
wow-miley merged 1 commit intoMay 25, 2026
Conversation
…erer Adds the JVM-side terminal renderer that writes ANSI escape sequences for a LumosTerminalFrame to a PrintStream. Implements LumosRenderer with cursor hide/show lifecycle, FULL and DIFFERENTIAL clear modes, run-length color optimization, shutdown-hook-driven start/stop, and polled cross-platform resize handling via an injectable TerminalSize provider. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wow-miley
deleted the
miley/pho-24-cliorb-lumosrendererlumosterminalframe-terminal-renderer
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliOrb, a JVMLumosRenderer<LumosTerminalFrame>that writes ANSI escape sequences to aPrintStream, completing the Wave 2 pipeline. SupportsFULLandDIFFERENTIALclear modes with run-length color optimization, cursor hide/show lifecycle, shutdown-hook-drivenstart()/stop(), and polled cross-platform resize handling via an injectableTerminalSizeprovider (system props → env vars → 80x24 fallback).TerminalSizeprovider interface and JVM default implementation, plus aClearModeenum.DIFFERENTIALno-op on unchanged frames and changed-cell-only emission on subsequent frames,start()/stop()shutdown semantics, no-op after stop, resize polling triggering a full redraw, and the missing-lattice error path.Closes #44
Test plan
./gradlew :phosphor-lumos-cli:jvmTest./gradlew jvmTest ktlintCheck