Skip to content

Fix http headers type #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nkzawa merged 2 commits into from
Aug 8, 2015
Merged

Fix http headers type #24

nkzawa merged 2 commits into from
Aug 8, 2015

Conversation

@nkzawa
Copy link
Contributor

@nkzawa nkzawa commented Jul 20, 2015

Set-Cookie header and custom headers can have multiple values, therefore Transport.EVENT_RESPONSE_HEADERS event and Transport.EVENT_RESPONSE_HEADERS event should take the type Map<String, List<String>> instead of Map<String, String>.
This is a backward incompatible change.

Related: socketio/socket.io-client-java#185

@nkzawa nkzawa mentioned this pull request Jul 20, 2015
Closed
@nkzawa nkzawa changed the title Fix headers type Fix http headers type Jul 23, 2015
nkzawa added a commit that referenced this pull request Aug 8, 2015
@nkzawa
Merge pull request #24 from nkzawa/fix-headers
3bcf06c 
Fix http headers type
@nkzawa nkzawa merged commit 3bcf06c into master Aug 8, 2015
@nkzawa nkzawa deleted the fix-headers branch December 23, 2015 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nkzawa