Skip to content

Added github pages documentation#2

Merged
trinopoty merged 8 commits intosocketio:masterfrom
trinopoty:documentation
Aug 10, 2018
Merged

Added github pages documentation#2
trinopoty merged 8 commits intosocketio:masterfrom
trinopoty:documentation

Conversation

@trinopoty
Copy link
Collaborator

@trinopoty trinopoty commented Aug 9, 2018

View documentation at https://socketio.github.io/engine.io-server-java/.
This adds much more documentation of the API and usage than README.

@codecov-io
Copy link

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   82.59%   82.59%           
=======================================
  Files          10       10           
  Lines         540      540           
  Branches       79       79           
=======================================
  Hits          446      446           
  Misses         61       61           
  Partials       33       33

Copy link
Member

@darrachequesne darrachequesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

docs/index.rst Outdated
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.

Welcome to Engine.IO's documentation!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "Java implementation" should be inserted somewhere, to clarify.

docs/using.rst Outdated
@@ -0,0 +1,89 @@
=====
Using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Getting started"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Using" to "Getting Started"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Totally cosmetic 😸

@trinopoty trinopoty merged commit c20085f into socketio:master Aug 10, 2018
@trinopoty trinopoty deleted the documentation branch August 10, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants