Skip to content

Close and free webSocketServer #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2016
Merged

Close and free webSocketServer #393

merged 1 commit into from
Oct 20, 2016

Conversation

@kapouer
Copy link
Contributor

@kapouer kapouer commented May 6, 2016

Is there an undocumented reason not to call ws.close() ?

@darrachequesne
Copy link
Member

darrachequesne commented Aug 5, 2016

Shouldn't this.ws.close() be surrounded with try .. catch?

@darrachequesne darrachequesne merged commit 724b3fd into socketio:master Oct 20, 2016
@darrachequesne
Copy link
Member

darrachequesne commented Oct 20, 2016

@kapouer thanks!

@darrachequesne darrachequesne added this to the 1.7.1 milestone Oct 20, 2016
@darrachequesne darrachequesne mentioned this pull request Oct 21, 2016
Merged
@darrachequesne darrachequesne mentioned this pull request Nov 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@kapouer @darrachequesne