Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ Server.prototype.close = function () {
if (this.ws) {
debug('closing webSocketServer');
this.ws.close();
delete this.ws;
// don't delete this.ws because it can be used again if the http server starts listening again
}
return this;
};
Expand Down
21 changes: 21 additions & 0 deletions test/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,27 @@ describe('server', function () {
});
});

it('should allow client reconnect after restarting (ws)', function (done) {
var opts = { transports: ['websocket'] };
var engine = listen(opts, function (port) {
engine.httpServer.close();
engine.httpServer.listen(port);

var socket = new eioc.Socket('ws://localhost:%d'.s(port), { transports: ['websocket'] });

engine.once('connection', function (conn) {
setTimeout(function () {
conn.close();
}, 10);
});

socket.once('close', function (reason) {
expect(reason).to.be('transport close');
done();
});
});
});

it('should trigger when client closes', function (done) {
var engine = listen({ allowUpgrades: false }, function (port) {
var socket = new eioc.Socket('ws://localhost:%d'.s(port));
Expand Down