[perf] websocket optimisation #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/transports/websocket.js
Outdated
| parser.encodePacket(packet, self.supportsBinary, parserCb); | ||
| } | ||
|
|
||
| function parserCb (data) { |
Member
There was a problem hiding this comment.
How about renaming that method send, to better reflect its purpose?
lib/transports/websocket.js
Outdated
| }); | ||
| }); | ||
| }); | ||
| function sendCb (err) { |
Member
There was a problem hiding this comment.
Same hère, how about something like onEnd?
Member
|
Hi, thanks for that PR! I made some minor comments, could you please check them? Did you see any other area of improvement? |
Contributor
Author
|
Will check tonight and change what you suggested |
That should be in your global .gitignore, shouldn't it?
Member
|
Thanks! |
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
Safely resolve `ws` module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
use forEach loop and anonymous functions
New behaviour
use for loop and cached function
Other information (e.g. related issues)
Why it's better to use cached functions: see this