Skip to content

Remove deprecated code used for nodejs v0.8 #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2016
Merged

Remove deprecated code used for nodejs v0.8 #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
254c125
Remove deprecated code used for nodejs v0.8
darrachequesne Dec 6, 2016
e379ad0
fix style
darrachequesne Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,6 @@ function Server (opts) {

var self = this;

// turn off per message deflate for node 0.8
// due to it not supporting DeflateRaw#close
// and thus not working with ws 0.8.x
if (/^v0\.8\./.test(process.version)) {
debug('perMessageDeflate not supported by node 0.8');
this.perMessageDeflate = false;
}

// initialize compression options
['perMessageDeflate', 'httpCompression'].forEach(function (type) {
var compression = self[type];
Expand Down
4 changes: 0 additions & 4 deletions test/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ var expect = require('expect.js');
var request = require('superagent');
var cookieMod = require('cookie');

// are we running on node 0.8?
var NODE_0_8 = /^v0\.8\./.test(process.version);
// are we running on node < 4.4.3 ?
var NODE_LT_443 = (function () {
var parts = process.versions.node.split('.');
Expand Down Expand Up @@ -2409,8 +2407,6 @@ describe('server', function () {
});

describe('permessage-deflate', function () {
if (NODE_0_8) return;

it('should set threshold', function (done) {
var engine = listen({ transports: ['websocket'], perMessageDeflate: { threshold: 0 } }, function (port) {
engine.on('connection', function (conn) {
Expand Down