Skip to content

Add proper response when handleUpgrade fails #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2016
Merged

Add proper response when handleUpgrade fails #458

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30655bb
Add proper response when handleUpgrade fails
darrachequesne Dec 7, 2016
a6e9570
grammar
darrachequesne Dec 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions lib/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ Server.prototype.handleUpgrade = function (req, socket, upgradeHead) {

var self = this;
this.verify(req, true, function (err, success) {
if (err) {
socket.end();
if (!success) {
abortConnection(socket, err);
return;
}

Expand Down Expand Up @@ -463,3 +463,27 @@ Server.prototype.attach = function (server, options) {
});
}
};

/**
* Closes the connection
*
* @param {net.Socket} socket
* @param {code} error code
* @api private
*/

function abortConnection (socket, code) {
if (socket.writable) {
var message = Server.errorMessages.hasOwnProperty(code) ? Server.errorMessages[code] : code;
var length = Buffer.byteLength(message);
socket.write(
'HTTP/1.1 400 Bad Request\r\n' +
'Connection: close\r\n' +
'Content-type: text/html\r\n' +
'Content-Length: ' + length + '\r\n' +
'\r\n' +
message
);
}
socket.destroy();
}