Graceful shutdown (feature request)

[ronkorving]

I would really appreciate a graceful shutdown function that would stop accepting new connections, but keep dealing with remaining active clients.

[heroic]

you could implement that urself for now... just check if the client.sessionId exists already in socket.clients, if not, then simply return

[rdzar]

A graceful shutdown (just to inform active connections) wouldn't hurt either. Now when killing the Node, the user 'thinks' he's still active while this actually isn't true. Those active clients should get a disconnect event directly on closing the Node app (listing to exit, sigint or sighup), so we can keep our data in the client queued while the Node gets fixed.

[thekiur]

why not something like this?

process.on('SIGINT', function() {
socket.sockets.send(JSON.stringify({
event : 'server-shutdown'
}));
process.exit();
});

and just parse the event on the client side?

[ronkorving]

Would those events be guaranteed to be sent before the process exits, or would a setTimeout make sense here?

[thekiur]

On my application, the shutdown events always end up in the clients (because seocket.sockets.send() blocks)

But a setTimeout wont hurt i guess

[davidmarkclements]

.. I'm pretty sure the setTimeout would never be called in this case since it would be called after the next tick, and there is no more ticks in the event of a SIGINT

[moll]

@davidmarkclements There are no more ticks after process.exit. Once you listen to SIGINT, the default handler (which happened to also be process.exit) won't fire.