Update slack badge as it's broken. #2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme.md
Outdated
| [](https://www.npmjs.com/package/socket.io) | ||
|  | ||
| [](http://slack.socket.io) | ||
| [](https://slackin-socketio.now.sh) |
Member
There was a problem hiding this comment.
Any particular reason not to use https://slackin-socketio.now.sh/badge.svg?
Contributor
Author
There was a problem hiding this comment.
Yeah i noticed that after making the PR. Will update. You must understand that took a bit of investigating to even figure out what was going on. Since it was the subdomain that was erroring. I figured better to have a finished stick figure than an unfinished Picasso :-). Updating now @darrachequesne.
Update badge to https://slackin-socketio.now.sh/badge.svg
Member
|
@snuggs thanks! 💃 |
mehdifilban
added a commit
to mehdifilban/socket.io
that referenced
this pull request
Sep 3, 2017
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
New behaviour
Other information (e.g. related issues)