Skip to content

Conversation

@einaros
Copy link
Contributor

@einaros einaros commented Nov 14, 2011

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a transport fails, or a client isn't properly verified, he will still be noted as connected. Adding this may possibly avoid a heap of strange errors reported elsewhere.

rauchg added a commit that referenced this pull request Nov 14, 2011
Bug fixes, and for some reason a heap of whitespace cleanups
@rauchg rauchg merged commit 7b6c850 into socketio:master Nov 14, 2011
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous origin tests weren't actually testing much at all, both due to puny tests and prblmz in manager.js. Now they should be all dandy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants