Target Rails main; drop actioncable-next dependency.#7
Merged
Conversation
The ActionCable::Server::Socket abstraction (rails/rails#50979) is now available in Rails main (8.1+), so the actioncable-next shim is no longer required. This branch tracks Rails main. The main branch continues to support stable Rails via actioncable-next.
Adds tests for: - Socket#request (both with and without Rails.application). - Socket#run rescue branch (websocket raising during send). - Middleware fall-through to inner app for non-websocket requests. - Middleware#allow_request_origin? same-host, allowed, and denied paths. - Middleware#handle_incoming_websocket abnormal-failure rescue. Brings line coverage from 81.58% to 100.0%.
samuel-williams-shopify
force-pushed
the
next
branch
from
2b20537 to
fb6ae03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ActionCable::Server::Socket abstraction (rails/rails#50979) is now available in Rails main (8.1+), so the actioncable-next shim is no longer required.
This branch tracks Rails main. The main branch continues to support stable Rails via actioncable-next.
Types of Changes
Contribution