Skip to content

Document child signal handling#66

Merged
samuel-williams-shopify merged 2 commits into
mainfrom
small-robustness-doc-cleanups
Jun 27, 2026
Merged

Document child signal handling#66
samuel-williams-shopify merged 2 commits into
mainfrom
small-robustness-doc-cleanups

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Document why forked children are created from a short-lived Thread.new.
  • Document why child execution resets SignalException handling after Thread.new.
  • Add regression coverage for the existing idempotent Channel#close behavior.

Testing

  • bundle exec sus --verbose test/async/container/channel.rb
  • bundle exec rubocop lib/async/container/channel.rb test/async/container/channel.rb
  • bundle exec sus --verbose

@samuel-williams-shopify samuel-williams-shopify force-pushed the small-robustness-doc-cleanups branch 2 times, most recently from 5e39833 to 8ccba54 Compare June 27, 2026 03:40
@samuel-williams-shopify samuel-williams-shopify changed the title Make channel cleanup idempotent Document child signal handling Jun 27, 2026
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4
@samuel-williams-shopify samuel-williams-shopify force-pushed the small-robustness-doc-cleanups branch from 8ccba54 to b3209f4 Compare June 27, 2026 03:41
@samuel-williams-shopify samuel-williams-shopify merged commit 9913c30 into main Jun 27, 2026
34 of 38 checks passed
@samuel-williams-shopify samuel-williams-shopify deleted the small-robustness-doc-cleanups branch June 27, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant