fix(server): silence EPIPE/ECONNRESET in accept loop#349
Open
fuleinist wants to merge 1 commit into
Open
Conversation
resolves socketry#333 When a client disconnects mid-response (e.g. browser navigation, WebSocket teardown, ALB health-check timeout), Async::HTTP::Server#accept raises Errno::EPIPE or Errno::ECONNRESET. These bubble up through the Async task runner and are logged as 'Task may have ended with unhandled exception.' by the runtime. These are expected, harmless disconnects — the client is simply gone. The fix rescues these two specific errors inside the track{} block so they propagate no further. All other exceptions continue to bubble up normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #333 — silences expected client-disconnect errors that otherwise flood logs with false alarms.
Problem
When a client disconnects mid-response (e.g. browser navigation, WebSocket teardown, ALB health-check timeout), the Async task runner logs:
This is particularly noisy with Hotwire/Turbo Drive, where every client-side navigation aborts the previous response.
Fix
Rescues Errno::EPIPE and Errno::ECONNRESET inside the track{} block in Falcon::Server#accept. These are not actionable errors — the client is simply gone. All other exceptions continue to bubble up normally.
Testing
The fix can be verified by rapidly navigating between pages in a Falcon-based app with Hotwire/Turbo Drive enabled — the console should no longer show the unhandled-exception warnings for normal client disconnects.