Function Type Updates#85
Merged
ioquatix merged 1 commit intosocketry:mainfrom Nov 13, 2024
Merged
Conversation
Member
|
@cfis do you mind checking CI failures? |
Collaborator
Author
|
Ah - it is because Clang is older than version 16. The function is only exposed on Clang 16 and higher https://github.com/ioquatix/ffi-clang/blob/main/lib/ffi/clang/lib/cursor.rb#L491 Should I do a gem check to see if the test should run or not? |
Member
|
Should we just update clang in CI? |
Collaborator
Author
|
That works for me. Clang is now up to version 19. Do you want to go with latest or do a matrix of 16, 17, 18, 19? |
Member
|
Honestly I think the latest is okay |
Collaborator
Author
|
Ok, I'll update make a separate PR with that change and then rebase this one on top of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support iterating over Type::Function args and expose Lib.get_non_reference_type.