Skip to content

Type Updates#90

Merged
ioquatix merged 1 commit intosocketry:mainfrom
cfis:named_type
Feb 16, 2025
Merged

Type Updates#90
ioquatix merged 1 commit intosocketry:mainfrom
cfis:named_type

Conversation

@cfis
Copy link
Copy Markdown
Collaborator

@cfis cfis commented Jan 31, 2025

Move #canonical from to the base Type class since it applies to all Types. Then add new Clang API, get_named_type.

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Jan 31, 2025

Hmm, not sure why this MR generated the CodeCompletion failures. I actually see those always when running tests locally but never on the test runner.

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Feb 1, 2025

See same on Fedora too, clang 19.1.7

@ioquatix
Copy link
Copy Markdown
Member

ioquatix commented Feb 1, 2025

I can take a look if that's helpful.

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Feb 1, 2025

That would be great. I've never seen code completion actually work locally but it has always worked on the CI/CD runner.

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Feb 4, 2025

Hi @ioquatix wondering if you had a chance to look yet?

I've been working on a gem to automatically create C (via FFI) and C++ (via Rice) bindings for Ruby, and I think its far enough along for an initial release. See https://github.com/ruby-rice/ruby-bindgen.

I have successfully used it to create new OpenCv bindings for Ruby - see https://github.com/cfis/ruby-opencv/tree/master/ext/opencv.

Anyway, I'd like to get a few last MR's into ffi-clang and then it would be great if we could do an official release. Then i can add it as dependency to ruby-bindgen.

Let me know if I can help!

@ioquatix
Copy link
Copy Markdown
Member

ioquatix commented Feb 4, 2025

That sounds great, sorry I have been busy, will try to make some time later this week to sort it out.

…ypes. Then add new Clang API, get_named_type.
@ioquatix
Copy link
Copy Markdown
Member

I could not figure out what was wrong, but it looks like install-llvm-action is not working on Ubuntu 24.04 - the previous environment was 22.04 which was passing okay.

I've opted just to use the standard packages as they are finally "modern" enough that I think it's good enough for CI.

@ioquatix ioquatix merged commit 9cb665d into socketry:main Feb 16, 2025
@ioquatix ioquatix self-assigned this Feb 16, 2025
@ioquatix ioquatix added this to the v0.13.0 milestone Feb 16, 2025
@ioquatix
Copy link
Copy Markdown
Member

Released in v0.13.0.

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Feb 16, 2025

Thanks!

@cfis
Copy link
Copy Markdown
Collaborator Author

cfis commented Feb 16, 2025

Question - are you still making github releases too (see https://github.com/ioquatix/ffi-clang/releases)?

@ioquatix
Copy link
Copy Markdown
Member

I find GitHub's release system far too manual for the volume of release I do. If you like, I'll create a releases.md document and we can add notes there about changes. It's my preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants