Skip to content

Search for phpcs.xml file in workspace root folder#29

Open
arisanguinetti wants to merge 1 commit intosoderlind:masterfrom
arisanguinetti:patch-1
Open

Search for phpcs.xml file in workspace root folder#29
arisanguinetti wants to merge 1 commit intosoderlind:masterfrom
arisanguinetti:patch-1

Conversation

@arisanguinetti
Copy link

This is my first time with vscode extensions, I think this change this might be useful.

This is my first time with vscode extensions, I think this change this might be useful.
@danieliser
Copy link

@soderlind Any chance this could be merged and extrapolated on?

There isn't really a reason why this shouldn't be automated entirely at this point, simply traversing from . relative to the file being formatted, to the workspace root checking for common phpcs file names and defaulting to them.

I'm in a situation currently that I have a default set in the workspace, but each submodule has its own gettext domains which we have rules for detecting when they are incorrect.

So we end up having to make a .vscode/settings.json file in each module to point to that modules rules file.

A standard traversal and search for common files would mean it always uses the closes, most relevant rules to the file being formatted.

@bdkoder
Copy link

bdkoder commented Feb 25, 2025

We also facing this issue. This PR would need merge ASAP.

@bdkoder
Copy link

bdkoder commented Feb 25, 2025

I wasted a full day for the issue, thanks a lot @arisanguinetti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants